Safeguard against already existing _acme-challenge records #6
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that sometimes my renewal would fail, either because of a timeout or something else. In these cases, the
_acme-challenge
record wouldn't be cleaned up and then any future runs of the renewal would then fail because the record already exists (ERROR: Response: {"result":null,"success":false,"errors":[{"code":81057,"message":"Record already exists."}],"messages":[]}
)This adds a simple check to see if the record already exists, and deletes it if it does. I considered trying to clean up after failure instead, but this actually catches other potential sources of
_acme-challenge
, such as if multiple tools are used.