Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added esbuild #635

Merged
merged 3 commits into from
Jul 15, 2024
Merged

Added esbuild #635

merged 3 commits into from
Jul 15, 2024

Conversation

Neizan93
Copy link
Contributor

@Neizan93 Neizan93 commented Oct 6, 2023 •
edited
Loading

Added ESBuild to fix optimization bailouts on TypeScript frameworks like Angular.

auvipy
auvipy requested changes Oct 8, 2023
View reviewed changes
Copy link
Member

@auvipy auvipy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you please share more context about the change requested?

@Neizan93
Copy link
Contributor Author

Neizan93 commented Oct 9, 2023

@auvipy it is the ECMAScript Module build with TypeScript types.
It is a simple PR to avoid the Angular (and other frameworks) message: "CommonJS or AMD dependencies can cause optimization bailouts" adding the package 'esbuild' with the generated build and types.d.ts for TypeScript usage.

@Neizan93
Copy link
Contributor Author

Neizan93 commented Oct 10, 2023 •
edited
Loading

To anyone that needs SockJS Client with TypeScript, Angular or ES Module (ECMAScript Module) y created the package:
https://www.npmjs.com/package/@tr0n0s/sockjs-client

@Neizan93 Neizan93 requested a review from auvipy October 13, 2023 08:47
@Neizan93 Neizan93 mentioned this pull request Oct 13, 2023
Open
@auvipy
Copy link
Member

auvipy commented Oct 14, 2023

thanks. I will merge it soon. just need to fix the CI from my side

@Neizan93
Copy link
Contributor Author

thanks. I will merge it soon. just need to fix the CI from my side

thank you =)

auvipy
auvipy requested changes Oct 28, 2023
View reviewed changes
Copy link
Member

@auvipy auvipy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you please add some tests to verify the proposed changes?

@lagoshny
Copy link

@Neizan93 , @auvipy Any news?

@auvipy auvipy merged commit 3637a38 into sockjs:main Jul 15, 2024
@lagoshny
Copy link

Great, thank you!
@auvipy Can you publish this changes in new lib version?

@auvipy
Copy link
Member

auvipy commented Sep 18, 2024 •
edited
Loading

we got an issue reported here #664, can you please fix this? @Neizan93

@Neizan93
Copy link
Contributor Author

we got an issue reported here #664, can you please fix this? @Neizan93

just delete package lock and install packages to fix it

@Neizan93 Neizan93 mentioned this pull request Oct 27, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@auvipy auvipy auvipy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Neizan93 @auvipy @lagoshny @JonatanMartinSgeMango