Getting Protected function call from public-API inline function is prohibited with Kotlin 1.4.0

[vanniktech]

#89 is no longer working for me

[sockeqwe]

Thanks for this.
But making it public would break too many apps out there (everyone would need to change their AdapterDelegates from protected to public if I'm not mistaken). I think we could wrap the AdapterDelegates into a public API version just for the inline DSL functions. This should solve calling protected methods from Inline dunctions and should not break all other AdapterDelegates out there. Will give it a try tomorrow.

[sockeqwe]

Wait, I just checked it the demo app and it compiles just fine with Kotlin 1.4.0.

I think I dont understand what your "modification does" so that it requires to make these methods to be public. Can you explain?

[vanniktech]

package com.hannesdorfmann.adapterdelegates4

import android.view.ViewGroup
import androidx.recyclerview.widget.RecyclerView
import com.hannesdorfmann.adapterdelegates4.dsl.AdapterDelegateViewHolder

@Suppress("UNCHECKED_CAST", "PROTECTED_CALL_FROM_PUBLIC_INLINE")
inline fun <Old, reified I : T, T> AdapterDelegate<List<Old>>.wrap(noinline mapper: (I) -> Old): AdapterDelegate<List<T>> {
  val listItemAdapterDelegate = this as AbsListItemAdapterDelegate<Old, Old, AdapterDelegateViewHolder<Old>>
  return object : AbsListItemAdapterDelegate<I, T, RecyclerView.ViewHolder>() {
    override fun isForViewType(item: T, items: MutableList<T>, position: Int): Boolean = item is I

    override fun onBindViewHolder(item: I, holder: RecyclerView.ViewHolder, payloads: MutableList<Any>) {
      listItemAdapterDelegate.onBindViewHolder(mapper.invoke(item), holder as AdapterDelegateViewHolder<Old>, payloads)
    }

    override fun onCreateViewHolder(parent: ViewGroup) = listItemAdapterDelegate.onCreateViewHolder(parent)
  }
}

[vanniktech]

I forked and made those methods public :/

Is there any update from your side?

[sockeqwe]

Not yet, haven't had time to work kn next version Niklas Baudy <[email protected]> schrieb am Mi., 11. Nov. 2020, 20:41:

…

I forked and made those methods public :/ Is there any update from your side? — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#94 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAEOPLSXA6WMEJCWVNZMZDTSPLSG3ANCNFSM4QI3EO5A> .

[vanniktech]

No longer need this 🤷