-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Patch: com.getvero #844
base: master
Are you sure you want to change the base?
Patch: com.getvero #844
Conversation
Thanks @misterpig ! |
@misterpig has signed the Software Grant and Corporate Contributor License Agreement |
Hey @BenFradet, @misterpig, I still have the same opinion I left in #842:
|
And also as I mentioned before, it seems we're using |
ok thanks, leaving in the 101 milestone for now. @misterpig if you could do the necessary changes, i.e. move to 2-0-0, we could integrate it into release 113. |
So the bug exists in the
campaign.id
field. Turns out the id field of this is an integer unlike theuser.id
field.Removing the
type
field wouldn't impact the adapter as the adapter removes the type field anyway; keeping type field in the schema is redundant as it'll contain NULL for every event after enrichment.Also increased the
campaign.permalink
field to accomodate long URLs.