Release R152 #1368
Merged
Release R152 #1368
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
istreeter
approved these changes
Jan 19, 2024
There was a problem hiding this comment.
From the point of view of the loaders, I don't see any problems.
I noticed that cross_navigation_config is the only schema without descriptions on the fields.
And I noticed that some files use tabs and some use spaces for whitespace. In case you care about that type of thing. (FWIW 189 out of 537 schemas in Iglu Central use tabs).
matus-tomlein
force-pushed
the
release/r152
branch
from
163b6b2
to
d0423c7
Compare
|
Thanks @istreeter! I have now converted the indentation to 2 spaces in all schemas and added field descriptions in |
rlh1994
approved these changes
Jan 22, 2024
schemas/com.snowplowanalytics.snowplow/cross_navigation/jsonschema/1-0-0
Outdated
Show resolved
Hide resolved
schemas/com.snowplowanalytics.snowplow/cross_navigation/jsonschema/1-0-0
Show resolved
Hide resolved
schemas/com.snowplowanalytics.snowplow/cross_navigation/jsonschema/1-0-0
Show resolved
Hide resolved
schemas/com.snowplowanalytics.snowplow/cross_navigation/jsonschema/1-0-0
Outdated
Show resolved
Hide resolved
matus-tomlein
force-pushed
the
release/r152
branch
from
d0423c7
to
b70fe3b
Compare
jbeemster
reviewed
Jan 25, 2024
schemas/com.snowplowanalytics.snowplow/cross_navigation/jsonschema/1-0-0
Outdated
Show resolved
Hide resolved
schemas/com.snowplowanalytics.snowplow/cross_navigation/jsonschema/1-0-0
Outdated
Show resolved
Hide resolved
…g/jsonschema/1-0-0
matus-tomlein
force-pushed
the
release/r152
branch
from
b70fe3b
to
5e025f1
Compare
jbeemster
approved these changes
Jan 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This release contains only new schemas.
visionOS events and entities (@mscwilson)
PR #1362
Add com.apple.swiftui/dismiss_immersive_space/jsonschema/1-0-0 (#1367)
Add com.apple.swiftui/open_immersive_space/jsonschema/1-0-0 (#1367)
Add com.apple.swiftui/dismiss_window/jsonschema/1-0-0 (#1367)
Add com.apple.swiftui/open_window/jsonschema/1-0-0 (#1367)
Add com.apple.swiftui/immersive_space/jsonschema/1-0-0 (#1367)
Add com.apple.swiftui/window_group/jsonschema/1-0-0 (#1367)
Mobile screen engagement tracking (@matus-tomlein)
PR #1358
Add com.snowplowanalytics.mobile/scroll_changed/jsonschema/1-0-0 (#1361)
Add com.snowplowanalytics.mobile/list_item_view/jsonschema/1-0-0 (#1360)
Add com.snowplowanalytics.mobile/screen_end/jsonschema/1-0-0 (#1357)
Add com.snowplowanalytics.mobile/screen_summary/jsonschema/1-0-0 (#1356)
Cross-navigation entity and config schema (@igneel64 and @adatzer)
PR #1347 and #1327
Add com.snowplowanalytics.snowplow.enrichments/cross_navigation_config/jsonschema/1-0-0
Add com.snowplowanalytics.snowplow/cross_navigation/jsonschema/1-0-0 (#1326)