-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update customServiceAPI.js #216
Open
giase82
wants to merge
1
commit into
snowdd1:master
Choose a base branch
from
giase82:patch-3
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This breaks knx support.
Can you figure out why the condition does not work for
knxconnection=='knxd'
? Maybe a missing pair of parentheses?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think one of the issues here is that I don’t understand what this piece of code is supposed to do, and why there is an exception for knxjs. I am missing information on why this !== ‘knxjs’ and !knxconnection is there at all. A short comment etc would be good.
I would expect
this.serviceKNX.globs.knxconnection !== 'knxjs'
should be “true”, since I am using knxd. However, apperently it isn’t. Another potential fix could be to addthis.serviceKNX.globs.knxconnection == 'knxd'
as “or”-condition. Like the following:if ((!this.serviceKNX.globs.knxconnection || this.serviceKNX.globs.knxconnection !== 'knxjs' || this.serviceKNX.globs.knxconnection == 'knxd') && temp.getDPT() === 'DPT5.001') {
Would that work?
In general (also related to your comments on other threads), I wonder if we should keep this as is and I switch over to knxjs. However, also in this case, it would be great to understand what’s different in knxjs compared to knxd regarding DPT5.001, and if I could still run knxd in parallel (for smarthomeng, for example).
Thanks for looking into this!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well, knxjs automatically translates 5.001 values to percentages, while using the
eibd
package we have to do it ourselves. So this if-block was supposed to run only ifeibd
package is still the defaultknxd
while the actual package name for the connector iseibd
though, my bad.This home bridge plug-in never installed a
knxd
server, that part needed to be done separately, so whatever you have been using outside of home bridge-knx is completely untouched by any change inside. I used theeibd
package to connect to a knxd server, using the proprietary protocol of this quite ancient tool.Since knxd has been completely revamped several years ago, it can work as a multicast router for knx-ip telegrams, which makes the whole stack for the proprietary protocol obsolete and it can be replaced by the much more lightweight
knx
package (was named knxjs before) which can speak to any knx-ip router, not only knxd-servers.