Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use supported package for slack #8867

Merged
merged 26 commits into from
Dec 15, 2020
Merged

use supported package for slack #8867

merged 26 commits into from
Dec 15, 2020

Conversation

alek13
Copy link
Contributor

@alek13 alek13 commented Dec 4, 2020

see maknz/slack#94

lost merged #8041

@alek13 alek13 requested a review from snipe as a code owner December 4, 2020 21:26
uberbrady
uberbrady previously approved these changes Dec 10, 2020
Copy link
Collaborator

@uberbrady uberbrady left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me; the old package does seem abandoned and the new fork does seem actively supported.

@snipe snipe changed the base branch from master to develop December 10, 2020 22:28
@snipe snipe changed the base branch from develop to master December 10, 2020 22:28
@snipe snipe dismissed uberbrady’s stale review December 10, 2020 22:28

The base branch was changed.

@snipe snipe changed the base branch from master to develop December 15, 2020 01:43
@snipe snipe merged commit fb37dbe into snipe:develop Dec 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants