Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed #16054: fix incorrect compose service name in the APP_KEY generation command of the Docker env file #16053

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

brlin-tw
Copy link

@brlin-tw brlin-tw commented Jan 10, 2025

This resolves the following error:

$ docker compose run --rm snipe-it php artisan key:generate --show
no such service: snipe-it

and is also how it is done in the documentation.

Refer-to: APP_KEY | Docker | Snipe-IT documentation https://snipe-it.readme.io/docs/docker#app_key

Note that the version in the master branch is also wrong, but the Contributing documentation says to target the develop branch so I'll leave it to you.

Fixes #16054

@brlin-tw brlin-tw requested a review from snipe as a code owner January 10, 2025 03:20
Copy link

welcome bot commented Jan 10, 2025

💖 Thanks for this pull request! 💖

We use semantic commit messages to streamline the release process and easily generate changelogs between versions. Before your pull request can be merged, you should update your pull request title to start with a semantic prefix if it doesn't have one already.

Examples of commit messages with semantic prefixes:

  • Fixed #<issue number>: don't overwrite prevent_default if default wasn't prevented
  • Added #<issue number>: add checkout functionality to assets
  • Improved Asset Checkout: use new notification method for checkout

Things that will help get your PR across the finish line:

  • Document any user-facing changes you've made.
  • Include tests when adding/changing behavior.
  • Include screenshots and animated GIFs whenever possible.

We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can.

Copy link

what-the-diff bot commented Jan 10, 2025

PR Summary

  • Update to Command Instructions
    The instruction for regenerating the APP_KEY has been updated. The command to be used has been corrected from snipeit to app. This change will make the instructions more accurate, preventing potential confusion and errors when regenerating the key.

…generation command of the Docker env file

This resolves the following error:

```
$ docker compose run --rm snipe-it php artisan key:generate --show
no such service: snipe-it
```

and is also how it is done in the documentation.

Fixes snipe#16054.

Refer-to: APP_KEY | Docker | Snipe-IT documentation <https://snipe-it.readme.io/docs/docker#app_key>
Signed-off-by: Buo-ren Lin (OSSII) <[email protected]>
@brlin-tw brlin-tw changed the title Fix incorrect compose service name in the APP_KEY generation command of the Docker env file Fixed #16054: fix incorrect compose service name in the APP_KEY generation command of the Docker env file Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant