Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes Accessory Checkout redirect to Checked out to error #16027

Closed
wants to merge 2 commits into from

Conversation

Godmartinz
Copy link
Collaborator

@Godmartinz Godmartinz commented Jan 6, 2025

This sets checkkout_to_type to user now. it was being set to null. redirecting to Checked Out To properly works now.
[sc-27684]

Copy link

what-the-diff bot commented Jan 6, 2025

PR Summary

  • Adjustment of Checkout Type
    The code previously relied on input from the user to determine the type of checkout. In this update, the code has been altered to always assume the checkout is being done by a user. This simplification should improve reliability by removing a potential source of user error.

@snipe
Copy link
Owner

snipe commented Jan 6, 2025

The checkout to type might not be user though - you can checkout accessories to assets, users and locations.

Screenshot 2025-01-06 at 8 04 07 PM

@Godmartinz Godmartinz closed this Jan 6, 2025
@Godmartinz
Copy link
Collaborator Author

im not seeing that here
image
also there is a note in the store method that was saying to do this:
image

@Godmartinz Godmartinz reopened this Jan 6, 2025
@Godmartinz
Copy link
Collaborator Author

oops, i needed to update my branch 🤦

@Godmartinz
Copy link
Collaborator Author

this seems to be fixed already.

@Godmartinz Godmartinz closed this Jan 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants