Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added tests around license checkin #15975

Merged
merged 3 commits into from
Dec 19, 2024

Conversation

marcusmoore
Copy link
Collaborator

This PR focuses on adding tests around checking in licenses via the UI but extracts a translation string along the way.

Copy link

what-the-diff bot commented Dec 16, 2024

PR Summary

  • Improved Error Messaging

    • The error message shown for licenses that cannot be reassigned has been updated. It now uses a translatable string, meaning it can be displayed in various languages as needed.
  • Better License Management

    • Two methods, reassignable and notReassignable, have been added to manage when licenses can or cannot be reassigned to different users or assets.
  • Expanded Language Support

    • A new language line has been added for the non-reassignable error message, supporting the above change for translatable strings.
  • More Robust Testing

    • New tests were added to ensure that the changes function as expected. These tests:
      • Confirm that attempting to check in a license that can't be reassigned triggers the correct error message.
      • Check that trying to check in an unassigned license also triggers the appropriate error message.
      • Validate that checking in licenses that are assigned to a user or asset works correctly.

@snipe snipe merged commit dc5dedd into snipe:develop Dec 19, 2024
9 checks passed
@marcusmoore marcusmoore deleted the testing/license-checkin branch December 19, 2024 22:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants