Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Accessory UI tests #15964

Merged
merged 2 commits into from
Dec 19, 2024
Merged

Conversation

marcusmoore
Copy link
Collaborator

This PR adds more tests around the UI for accessories.

@marcusmoore marcusmoore requested a review from snipe as a code owner December 12, 2024 22:33
Copy link

what-the-diff bot commented Dec 12, 2024

PR Summary

  • Simplified View Path Syntax
    The way our systems point to certain views, or pages, in the AccessoriesController was updated to use a cleaner format called dot notation.

  • Enhanced Test for Accessories Page
    Our test for the accessories page AccessoriesIndexTest has been improved. It now also checks whether the accessories page gets displayed correctly.

  • Added Multiple Checkpoints for Deleting Accessories
    A new test series, 'DeleteAccessoryTest', has been created. It includes several checks when deleting an accessory, such as permission requirements, preventing deletion across different companies, inhibitions for items that are checked out, and verifying successful deletion.

  • Established Preconditions for Viewing Accessories
    'ShowAccessoryTest' was added, which defines several preconditions for viewing an accessory. These include permission levels, access limits to the data of the same company, and viewing the correct accessory data.

  • Revised Accessory Update Test Mechanism
    The 'UpdateAccessoryTest' is now even more robust. It includes checks for access permissions for modifications, successful rendering of the editing page, restrictions on editing data from other companies, validation for stock-check against checked-out items, and successful update operation verifications.

@snipe
Copy link
Owner

snipe commented Dec 12, 2024

You might want to look at my pending accessories to locations + assets PR, I might have covered a few of these already.

@marcusmoore
Copy link
Collaborator Author

Do you mean #15913? It doesn't look like there is overlap but I'm ok with this waiting for that one to get merged first. I can catch it up afterwards.

@snipe snipe merged commit 23af5fb into snipe:develop Dec 19, 2024
8 of 9 checks passed
@marcusmoore marcusmoore deleted the testing/accessories-ui branch December 19, 2024 22:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants