Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed the notification listener #14268

Merged
merged 1 commit into from
Feb 15, 2024
Merged

Conversation

Godmartinz
Copy link
Collaborator

Description

The notificication listener was not firing on check ins for the general webhook. Its fixed now.

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • [ x] Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Test Configuration:

  • PHP version:
  • MySQL version
  • Webserver version
  • OS version

Checklist:

Copy link

what-the-diff bot commented Feb 14, 2024

PR Summary

  • Condition Added in Webhook Notification System
    This change involves additional checks before a webhook notification is dispatched. Now, this notification will only be sent if the chosen setting for webhooks is either 'slack' or 'general'. This helps ensure that we don't send unwanted notifications and respect the user's preference for the notification system.

@snipe snipe merged commit 1fa8fba into snipe:develop Feb 15, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants