Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolves Issue with Asset Model Default Updates #14259

Closed
wants to merge 4 commits into from

Conversation

spencerrlongg
Copy link
Collaborator

Description

This resolves an issue where updating an Asset Model's defaults would throw an incorrect and vague validation error - the issue has something to do with the custom not_array validation rule on checkboxes.

This is just a temporary fix to get the GUI functionality working again, the only regression this should introduce is the fact that you can now trigger an exception by submitting an array to a custom field checkbox via the API.

I'm going to start working on a new branch today to properly validate checkboxes and fully resolve this issue, but wanted to get this in quickly to resolve the GUI issue.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

@spencerrlongg spencerrlongg requested a review from snipe as a code owner February 13, 2024 19:54
Copy link

Copy link

what-the-diff bot commented Feb 13, 2024

PR Summary

  • Introduction of a Temporary Fix in GUI
    This update introduces a temporary workaround to address an issue where the default settings within the model of the graphical user interface (GUI) weren't updating as expected.

@spencerrlongg
Copy link
Collaborator Author

Getting close to actually wrapping up the full fix for this, so gonna go ahead and close this (also because I was working off of the same branch without thinking so now this is more than what the description says)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant