Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #14010 Adds Components and Licenses logs to Assets history view #14197

Conversation

inietov
Copy link
Collaborator

@inietov inietov commented Feb 1, 2024

Description

When retrieven the Asset's log actions in the asset view, only actions performed by the asset where shown. But if we have checkins/checkouts of licenses or components to that same asset those aren't even when the system does logs them.

I tweak the eloquent query in the report controller so the asset history tab view also show those actions.

Fixes #14010

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Test Configuration:

  • PHP version: 8.1
  • MySQL version: 8.0.31
  • Webserver version: PHP dev server
  • OS version: Debian 11

Copy link

what-the-diff bot commented Feb 1, 2024

PR Summary

  • Modification to Reports Controller File
    The logic in the ReportsController.php file underwent changes, making the system more advanced in filtering action logs—an activity record. The filtering is now more meticulous, using both item identification and type.

  • Additional Condition for Filtering
    There is now a more refined filtering condition in place. Action logs can be sorted out not just by 'item_id' and 'item_type', but also by 'target_id' and 'target_type'. It broadens the search and filtering capacity of the system.

  • Improved Logic for Target Type Assignment
    Instead of hardcoding values, the 'target_type' parameter now smartly adapts the 'item_type' value and capitalizes it for use. This makes the system more adaptable to changing conditions and reduces the need for manual intervention.

@snipe snipe merged commit d8b1eec into snipe:develop Feb 15, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants