-
-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Resolve Duplicate Activity Logs for Imports #14172
Conversation
This pull request has been linked to Shortcut Story #23514: Newly imported assets appear twice in Activity report. |
PR Summary
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I dig it 👍🏾 nice solution 😄
Changed this to set the |
@snipe quick poke on this |
Description
Resolves the issue with duplicate activity logs for items that were created using the importer by setting an attribute on the Loggable trait and removing the specific log point on the importer classes, setting the attribute at import time, and then checking for it on the observer to set the note correctly.
Also added a sample CSV for Components.
Fixes SC:23514
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Tested each of the import types to make sure no more duplicates and that they were logged correctly.
Test Configuration:
Checklist: