Improved radio button values in custom report form

[marcusmoore]

Description

This is a tiny PR that supports an upcoming feature. The change adds more explicit values to the following radio buttons on the custom report page:

Specifically it sets an actual value, exclude_deleted, for the default radio button. Again, this is to support a future feature.

Type of change

• Bug fix (ish) (non-breaking change which fixes an issue)

How Has This Been Tested?

I tested this by deleting an asset and running the report with the three options to make sure behavior didn't break.

[shortcut-integration]

This pull request has been linked to Shortcut Story #24501: Improve radio button values in custom report form.

[what-the-diff]

PR Summary

• Update in Asset Condition Checks in ReportsController.php
  The logic for determining the status of deleted_assets has been made more intuitive and understandable. It was previously using '1' and '0' as determinants, but now it's using string descriptions, namely 'include_deleted' and 'only_deleted', making it much easier to understand its function.

• Modification of Values for Radio Buttons in custom.blade.php
  The same change also flows into the front-end UI for users. The radio buttons corresponding to deleted_assets in our display interface use the same understandable terms 'exclude_deleted', 'include_deleted', 'only_deleted' instead of just '1' ,'0', or an empty string. This improves the overall user experience by making selections much clearer.

[uberbrady]

This is much clearer, and looks really understandable at a glance. Nice!