Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds translations for Label example #14131

Merged
merged 2 commits into from
Jan 24, 2024

Conversation

Godmartinz
Copy link
Collaborator

@Godmartinz Godmartinz commented Jan 16, 2024

Description

This adds translations for the example texts provided and the label options in #13680.

Fixes #SC-24019

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • [ x] New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Test Configuration:

  • PHP version:
  • MySQL version
  • Webserver version
  • OS version

Checklist:

Copy link

what-the-diff bot commented Jan 16, 2024

PR Summary

  • Dynamic Translation Integration
    The pull request enriches the multi-language support of the application. By transforming static names in different data array elements like 'company', 'defaultLoc', 'location', 'model', 'manufacturer', 'supplier', etc., to dynamic translations in LabelsController.php, the application can now provide content in different languages that user prefers. This feature is essential in tailoring the user experience to individual's local settings, hence a more personalized, enjoyable interface.

  • Addition of New Placeholder Translations
    A variety of placeholder translations were added in the table.php file found under the admin/labels directory. These entries such as 'Test Company Limited', 'Building 1', 'Test Category', 'Building 2', 'Test Manufacturing Inc.', 'Test Model' and 'Test Company Limited', act as templates for various data components throughout the application. Anytime the system needs to present such elements, these new translations will be used to fill those spots. This greatly helps with the consistency and standardization across the system and strengthens our translation system overall.

@Godmartinz Godmartinz marked this pull request as draft January 16, 2024 19:35
@Godmartinz Godmartinz marked this pull request as ready for review January 16, 2024 20:05
Copy link
Collaborator

@marcusmoore marcusmoore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks for following up 😄

@Godmartinz Godmartinz changed the title adds translations for Label example Adds translations for Label example Jan 22, 2024
@snipe snipe merged commit 661cc2b into snipe:develop Jan 24, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants