Fixed #13723 - race condition on asset observer for older migration

[snipe]

This should fix #13723, where there was a race condition firing a migration from earlier in 2023 which modifies the asset, but the observer touches fields that have not yet been created.

I mostly hate this (especially because we're going back in time to fix migrations) but this seems like the most sane way to clear the upgrade path.

[shortcut-integration]

This pull request has been linked to Shortcut Story #23830: 2023_01_21_225350_add_eol_date_on_assets_table - migration fails to add eol_explicit column on older migrations.

[what-the-diff]

PR Summary

• Code commenting in AssetObserver.php file
  The PR comprises a valuable addition of explanatory comments to the saving function within the AssetObserver.php file, allowing for better code understanding and smoother maintenance.

• New assets table structure
  The PR introduces a new migration file which modifies the assets table structure by introducing new fields - asset_eol_date and eol_explicit. This modification will enhance data organization by including valuable information about the end-of-life date of an asset.

• Addition of eol_explicit column if non-existent
  The PR includes another migration file which evaluates the existence of the eol_explicit column within the assets table. Should the column be non-existent, the migration file facilitates its creation. This offers flexibility and ensures the data integrity of the assets table.

[uberbrady]

This seems like a reasonable way to solve the problem. I think there are ways to save without firing observers, which might be another way to go about it - but this certainly does do the trick.

[snipe]

Hm, good point. I could perhaps try saveQuietly() and/or withoutEvents() in that older migration...

[snipe]

@uberbrady can you peep this updated version?

[uberbrady]

I like this, it seems a bit cleaner - but if we really want to belt-and-suspenders this, I think it makes sense to have both in there at the same time. Especially since it’s so hard to test, I think I like that idea of trying to throw everything at the wall and just seeing what sticks.