-
-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added trim to import values #13731
Added trim to import values #13731
Conversation
Signed-off-by: snipe <[email protected]>
PR Summary
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can't figure out any side effects of this, nor can I figure out a decent way to 'move it up a level' to avoid putting it on every line, so 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's a syntax error that needs to be fixed but other than that, I agree with Spencer's comments.
Co-authored-by: Marcus Moore <[email protected]>
This just adds some
trim()
methods around the imported field values. We recently had a customer who ended up with duplicate statuses, sinceReady to Deploy
andReady to Deploy
are not the same string.I'm not 100% sure I've gotten everything in this PR, but I'll keep testing.