Return 404 if download file isn’t found

Signed-off-by: snipe <[email protected]>
snipe · Feb 19, 2024 · c76fbe4 · c76fbe4
1 parent cae2de4
commit c76fbe4
Showing 1 changed file with 4 additions and 3 deletions.
diff --git a/app/Http/Controllers/Api/SettingsController.php b/app/Http/Controllers/Api/SettingsController.php
@@ -267,12 +267,13 @@ public function listBackups() {
 
     public function downloadBackup($file) {
 
-        $path = 'app/backups';
-        if (Storage::exists($path.'/'.$file)) {
+        $path = storage_path('app/backups');
+
+        if (Storage::exists('app/backups/'.$file)) {
             $headers = ['ContentType' => 'application/zip'];
             return response()->download($path.'/'.$file, $file, $headers);
         } else {
-            return response()->json(Helper::formatStandardApiResponse('error', null,  trans('general.file_not_found')));
+            return response()->json(Helper::formatStandardApiResponse('error', null,  trans('general.file_not_found')), 404);
         }
 
     }