Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: print run id to log #10

Merged
merged 4 commits into from
Feb 1, 2024
Merged

feat: print run id to log #10

merged 4 commits into from
Feb 1, 2024

Conversation

fgvieira
Copy link
Contributor

@fgvieira fgvieira commented Dec 29, 2023 •
edited
Loading

Print run run_uuid to log.

@fgvieira fgvieira changed the title Print run id to log feat: print run id to log Dec 29, 2023
@fgvieira fgvieira requested a review from cmeesters January 10, 2024 12:07
@cmeesters
Copy link
Member

Good idea! Yet, the job id is not the jobname (see comment to #16). The job id is slurm_jobid and just known after submission. And it is reported in lines 149-154 (current code).

@fgvieira
Copy link
Contributor Author

fgvieira commented Jan 10, 2024 •
edited
Loading

Not sure I follow... Here I am referring to the run uuid, not the job id or the slurm job id. The idea is to have a quick way to check which jobs a certain workflow submitted to slurm.

@fgvieira fgvieira enabled auto-merge (squash) January 18, 2024 10:48
cmeesters
cmeesters approved these changes Feb 1, 2024
View reviewed changes
Copy link
Member

@cmeesters cmeesters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry for the lag

@fgvieira fgvieira merged commit 9ee8291 into snakemake:main Feb 1, 2024
4 checks passed
@github-actions github-actions bot mentioned this pull request Feb 1, 2024
Merged
cmeesters pushed a commit that referenced this pull request Feb 1, 2024
@github-actions
chore(main): release 0.3.0 (#32)
5dfd514 
🤖 I have created a release *beep* *boop*
---


##
[0.3.0](v0.2.2...v0.3.0)
(2024-02-01)


### Features

* print run id to log
([#10](#10))
([9ee8291](9ee8291))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@fgvieira fgvieira deleted the run_id branch February 2, 2024 06:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmeesters cmeesters cmeesters approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fgvieira @cmeesters