fix #163

db/functions/FWA_Downstream.sql

@@ -65,7 +65,8 @@ CREATE OR REPLACE FUNCTION whse_basemapping.FWA_Downstream(
     localcode_ltree_b ltree
 )
 
-RETURNS boolean AS $$
+RETURNS boolean language sql set search_path = public AS $$
+
 
 SELECT
 -- watershed code a is a descendant of watershed code b
@@ -87,7 +88,7 @@ SELECT
   )
 
 $$
-language 'sql' immutable parallel safe;
+immutable parallel safe;
 
 
 
@@ -105,9 +106,7 @@ CREATE OR REPLACE FUNCTION whse_basemapping.FWA_Downstream(
     tolerance double precision default .001
 )
 
-RETURNS boolean AS $$
-
-
+RETURNS boolean language sql set search_path = public AS $$
 
   SELECT
 
@@ -186,7 +185,7 @@ RETURNS boolean AS $$
 END
 
 $$
-language 'sql' immutable parallel safe;
+immutable parallel safe;
 
 CREATE OR REPLACE FUNCTION whse_basemapping.FWA_Downstream(
     blue_line_key_a integer,
@@ -201,7 +200,7 @@ CREATE OR REPLACE FUNCTION whse_basemapping.FWA_Downstream(
     tolerance double precision default .001
 )
 
-RETURNS boolean AS $$
+RETURNS boolean language sql set search_path = public AS $$
 
 SELECT
   whse_basemapping.FWA_Downstream(
@@ -219,6 +218,6 @@ SELECT
   )
 
 $$
-language 'sql' immutable parallel safe;
+immutable parallel safe;
 
 --COMMENT ON FUNCTION FWA_Downstream IS 'Compare input watershed codes and/or linear positions A and B, return TRUE if codes/positions A are downstream of codes/positions B';

db/functions/FWA_StreamsAsMVT.sql

@@ -4,6 +4,7 @@ RETURNS bytea
 AS $$
 DECLARE
     result bytea;
+
 BEGIN
     WITH
 

db/functions/FWA_Upstream.sql

@@ -62,8 +62,6 @@ return TRUE when the values for b are upstream of the values for a.
 
 */
 
--- ensure the functions are created in the public schema
-set search_path to public;
 
 -- watershed code comparison only
 CREATE OR REPLACE FUNCTION whse_basemapping.FWA_Upstream(
@@ -75,6 +73,8 @@ CREATE OR REPLACE FUNCTION whse_basemapping.FWA_Upstream(
 
 RETURNS boolean AS $$
 
+SET search_path TO public,whse_basemapping,usgs,hydrosheds;
+
 SELECT
   -- Simple case, where watershed code and local code of (a) are equivalent.
   -- Return TRUE for all records in (b) that are children of (a)
@@ -130,7 +130,8 @@ CREATE OR REPLACE FUNCTION whse_basemapping.FWA_Upstream(
     tolerance double precision default .001
 )
 
-RETURNS boolean AS $$
+RETURNS boolean language sql set search_path = public AS $$
+
 
 SELECT
   -- b is a child of a, always
@@ -222,7 +223,7 @@ SELECT
     END
   )
 $$
-language 'sql' immutable parallel safe;
+immutable parallel safe;
 
 
 -- shortcut for points, dnstr measure a and upstr measure are equivalent
@@ -239,7 +240,7 @@ CREATE OR REPLACE FUNCTION whse_basemapping.FWA_Upstream(
     tolerance double precision default .001
 )
 
-RETURNS boolean AS $$
+RETURNS boolean language sql set search_path = public AS $$
 
 SELECT
   whse_basemapping.FWA_Upstream(
@@ -256,7 +257,7 @@ SELECT
     tolerance
   )
 $$
-language 'sql' immutable parallel safe;
+immutable parallel safe;
 
 
 --COMMENT ON FUNCTION FWA_Upstream IS 'Compare input watershed codes and/or linear positions A and B, return TRUE if codes/positions A are upstream of codes/positions B';

db/functions/FWA_UpstreamBorderCrossings.sql

@@ -4,6 +4,7 @@ RETURNS text
 
 AS $$
 
+
 WITH local_segment AS
 (
   SELECT

db/functions/FWA_WatershedHex.sql

@@ -15,7 +15,6 @@ declare
    v_blkey    integer := blue_line_key;
    v_measure  float := downstream_route_measure;
 
-
 begin
 
 return query

db/functions/FWA_WatershedStream.sql

@@ -16,7 +16,6 @@ declare
    v_blkey    integer := blue_line_key;
    v_measure  float := downstream_route_measure;
 
-
 begin
 
 return query

db/functions/ST_Safe_Repair.sql

@@ -36,6 +36,7 @@ create or replace function ST_Safe_Repair(
     message text default '[unspecified]'
 ) returns geometry as
 $$
+
 begin
     if ST_IsEmpty(geom)
     then

db/functions/hydroshed.sql

@@ -8,6 +8,7 @@ AS
 
 $$
 
+
 WITH RECURSIVE walkup (hybas_id, geom) AS
     (
         SELECT hybas_id, wsd.geom