Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IEquality Hotfix #817

Merged
merged 5 commits into from
Dec 16, 2024
Merged

Conversation

nbollis
Copy link
Member

@nbollis nbollis commented Dec 13, 2024

Last IEquality adjustment broke a few things in MetaMorpheus. This PR rectifies that and adds default interface implementations, pointing the derived classes at that default.

  • Added IEquatable<IBioPolymer> and IEquatable<IBioPolymerWithSetMods> implementations in IBioPolymer.cs and IBioPolymerWithSetMods.cs.
  • Updated Equals and GetHashCode methods in Protein.cs and PeptideWithSetModifications.cs to use the new interface.
  • Added new test cases in TestOligoWithSetMods.cs to verify equality and inequality.
  • Updated Equals and GetHashCode methods in OligoWithSetMods.cs and NucleicAcid.cs to use the new interface.

@nbollis nbollis added the bug label Dec 13, 2024
Copy link

codecov bot commented Dec 13, 2024

Codecov Report

Attention: Patch coverage is 91.66667% with 4 lines in your changes missing coverage. Please review.

Project coverage is 77.25%. Comparing base (21c1702) to head (2c88027).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
...zLib/Transcriptomics/Digestion/OligoWithSetMods.cs 71.42% 1 Missing and 1 partial ⚠️
mzLib/Omics/Digestion/DigestionAgent.cs 83.33% 0 Missing and 1 partial ⚠️
mzLib/Omics/IBioPolymerWithSetMods.cs 88.88% 0 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #817      +/-   ##
==========================================
+ Coverage   77.23%   77.25%   +0.02%     
==========================================
  Files         218      218              
  Lines       33014    33014              
  Branches     3422     3422              
==========================================
+ Hits        25499    25506       +7     
+ Misses       6942     6941       -1     
+ Partials      573      567       -6     
Files with missing lines Coverage Δ
mzLib/Omics/IBioPolymer.cs 87.50% <100.00%> (+87.50%) ⬆️
mzLib/Proteomics/Protein/Protein.cs 95.73% <100.00%> (+0.32%) ⬆️
...roteolyticDigestion/PeptideWithSetModifications.cs 96.09% <100.00%> (+0.20%) ⬆️
mzLib/Proteomics/ProteolyticDigestion/Protease.cs 95.56% <ø> (+0.38%) ⬆️
mzLib/Transcriptomics/Digestion/Rnase.cs 100.00% <ø> (ø)
mzLib/Transcriptomics/NucleicAcid.cs 92.70% <100.00%> (-0.31%) ⬇️
mzLib/Omics/Digestion/DigestionAgent.cs 89.47% <83.33%> (-0.92%) ⬇️
mzLib/Omics/IBioPolymerWithSetMods.cs 97.64% <88.88%> (-1.04%) ⬇️
...zLib/Transcriptomics/Digestion/OligoWithSetMods.cs 86.88% <71.42%> (-0.67%) ⬇️

... and 1 file with indirect coverage changes

@nbollis nbollis marked this pull request as ready for review December 13, 2024 06:41
@Alexander-Sol Alexander-Sol merged commit d98326b into smith-chem-wisc:master Dec 16, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants