-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extended IBioPolymerWithSetMods interface, changed hashcodes #811
Merged
trishorts
merged 13 commits into
smith-chem-wisc:master
from
Alexander-Sol:PolymerWSetModsChange
Dec 12, 2024
Merged
Extended IBioPolymerWithSetMods interface, changed hashcodes #811
trishorts
merged 13 commits into
smith-chem-wisc:master
from
Alexander-Sol:PolymerWSetModsChange
Dec 12, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ation in Peptide and Oligo wsetmods
…Sol/mzLib into PolymerWSetModsChange
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #811 +/- ##
==========================================
+ Coverage 77.21% 77.23% +0.02%
==========================================
Files 218 218
Lines 32964 33014 +50
Branches 3413 3422 +9
==========================================
+ Hits 25453 25499 +46
+ Misses 6944 6942 -2
- Partials 567 573 +6
|
trishorts
approved these changes
Dec 4, 2024
nbollis
approved these changes
Dec 10, 2024
RayMSMS
approved these changes
Dec 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IBioPolymerWithSetMods is used as a dictionary key in MetaMorpheus. However, as it doesn't implement an IEquatable interface, equality comparison is done by reference, instead of by calling the Equals method (I think).
This PR adds the IEquatable interface to the IBioPolymerWithSetMods interface.
The HashCode methods for classes that implement IBioPolymerWithSetMods are still the same. This is fine, as the Equals method is used to make the final determination of what is and is not a unique entry in a dictionary.