Implemented SpectrumTree Class #678
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #678 +/- ##
==========================================
- Coverage 81.30% 80.99% -0.31%
==========================================
Files 153 142 -11
Lines 25970 25576 -394
==========================================
- Hits 21115 20716 -399
- Misses 4855 4860 +5
|
nbollis
approved these changes
Dec 19, 2022
avcarr2
approved these changes
Jan 20, 2023
acesnik
reviewed
Feb 7, 2023
| { | ||
| _currentNode = null; | ||
| _nextNode = SpectrumTree.GetMinNode(_rootNode); | ||
| } |
There was a problem hiding this comment.
Might be easy to add tests for Reset() method and .Current field
acesnik
approved these changes
Feb 7, 2023
| { | ||
| node.parent.leftChild = node.leftChild; | ||
| node.leftChild.parent = node.parent; | ||
| return; |
There was a problem hiding this comment.
Looks like there are some adjacent node cases that aren't tested
|
There are a few small places where you could add tests, but no need to do that before merging unless you feel like it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The spectrum tree is a basic Binary Search Tree storing mz, intensity pairs. The nodes are ordered by m.z.
This data structure will allow for efficient search and deletion. It will be used for efficiently aligning two spectra, as is required by spectral similarity.