Fixed decoy order (#809)

mzLib/Test/DatabaseTests/TestDatabaseLoaders.cs

@@ -110,9 +110,8 @@ public void LoadingIsReproducible(string fileName, DecoyType decoyType)
 
             // check are equivalent lists of proteins
             Assert.AreEqual(proteins1.Count, proteins2.Count);
-            // Because decoys are written in a parallel environment, there is no guarantee that the orders will be the same
-            CollectionAssert.AreEquivalent(proteins1.Select(p => p.Accession), proteins2.Select(p => p.Accession));
-            CollectionAssert.AreEquivalent(proteins1.Select(p => p.BaseSequence), proteins2.Select(p => p.BaseSequence));
+            // Because decoys are sorted before they are returned, the order should be identical
+            Assert.AreEqual(proteins1, proteins2);
         }
 
         [Test]

mzLib/UsefulProteomicsDatabases/DecoyProteinGenerator.cs

@@ -180,6 +180,7 @@ private static List<Protein> GenerateReverseDecoys(List<Protein> proteins, int m
 
                 lock (decoyProteins) { decoyProteins.Add(decoyProtein); }
             });
+            decoyProteins = decoyProteins.OrderBy(p => p.Accession).ToList();
             return decoyProteins;
         }
 
@@ -359,6 +360,7 @@ private static List<Protein> GenerateSlideDecoys(List<Protein> proteins, int max
                     protein.Name, protein.FullName, true, protein.IsContaminant, null, decoyVariationsSlide, null, protein.SampleNameForVariants, decoy_disulfides_slide, spliceSitesSlide, protein.DatabaseFilePath);
                 lock (decoyProteins) { decoyProteins.Add(decoyProteinSlide); }
             });
+            decoyProteins = decoyProteins.OrderBy(p => p.Accession).ToList();
             return decoyProteins;
         }