Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

1.7.x: Add option to allow using field title instead of name when saving data #208

Open
wants to merge 1 commit into
base: 1.7-maintenance
Choose a base branch
from
Open

1.7.x: Add option to allow using field title instead of name when saving data #208

wants to merge 1 commit into from

Conversation

malthe
Copy link

@malthe malthe commented Dec 12, 2017

This implements proposal #207.

@malthe
Copy link
Author

malthe commented Dec 12, 2017

If someone uses Plone 5 and wants to apply this first to master ... then great :-)

mauritsvanrees
mauritsvanrees requested changes Dec 19, 2017
View reviewed changes
Copy link
Collaborator

@mauritsvanrees mauritsvanrees left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't tried it, but it LGTM.
Travis fails though. Can you have a look?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mauritsvanrees mauritsvanrees mauritsvanrees requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@malthe @mauritsvanrees