support different Pinecone initialization depending on the version #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DosticJelena
force-pushed
the
client-upgrade-support
branch
from
e7577cf to
0b016da
Compare
|
LGTM! |
DosticJelena
force-pushed
the
client-upgrade-support
branch
from
0b016da to
271e3aa
Compare
|
❗ @DosticJelena plz hold off on merging this if possible -- I changed a few things around because of how we have to unit test the dynamic import of That draft PR ^ also has unit tests for this change ✅ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added changes to support the new version of pinecone-client.
The initialization process has changed from the module level to the class level.
Note: Do not merge this PR