Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hybrid search optimizations #3

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Hybrid search optimizations #3

wants to merge 1 commit into from

Conversation

DosticJelena
Copy link

Changes included in this PR:

  • created new type VectorStoreSparseEncoder and added new field of that type to PineconeVectorStore
  • added SPLADE and BM25 (beside SparseDict) from pinecone_text library as sparse/hybrid query mode options
  • included query_embedding to all query modes
  • added vector store and query mode compatibility check

Note: Please do not merge this PR

@DosticJelena DosticJelena force-pushed the hybrid_search_optimizations branch from 1b69715 to 69f5a13 Compare October 24, 2023 11:53
jamescalam
jamescalam approved these changes Oct 30, 2023
View reviewed changes
Copy link

@jamescalam jamescalam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! Thanks!

@DosticJelena DosticJelena force-pushed the hybrid_search_optimizations branch from 69f5a13 to b821625 Compare November 22, 2023 09:45
@DosticJelena DosticJelena force-pushed the hybrid_search_optimizations branch from 8ba159f to 93d9eee Compare December 29, 2023 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jamescalam jamescalam jamescalam approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DosticJelena @jamescalam