Fix missing icons and wrong styling for download menu #262
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
In addition to this changes, this PR slub/slub_digitalcollections#65 fixes the page pdf icon |
beatrycze-volk
requested changes
Dec 4, 2023
Signed-off-by: Christos Sidiropoulos <[email protected]>
Signed-off-by: Christos Sidiropoulos <[email protected]>
Signed-off-by: Christos Sidiropoulos <[email protected]>
csidirop
force-pushed
the
bugfix/fixDownloadIcons
branch
from
06776e9 to
a256375
Compare
beatrycze-volk
approved these changes
Dec 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes some missing icons and corrects the styling for the
imagedownloadtoolandfulltextdownloadtool:The
fulltextdownloadtoolmissed an icon if there was no fulltext.The
imagedownloadtoolhad no icon at all. So I reused one which belongs to the pdf page download button. Furthermore it fixed the opacity.And in the doublepageview:
As you can see, for some reason the imagedownloadtool had a second
::beforeelement and was wrapped in aspan. I was not able to find the reason for the existence of the second element, so maybe it was mistake?I have tried to work around the problem, at least for now, by hiding it and moving the text. Only drawback is that in the doublepageview the download for the second page image is now missing all
::beforeelements.What do you think?
Also I left both tools active. I thought that since DFG-Viewer is a reference implementation, it should also show what it can do by default. But thats only my opinion and can be easily undone.