Grunt action to verify if compiled files are up to date #261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Verifies compiled files are up to date Signed-off-by: Christos Sidiropoulos <[email protected]>
beatrycze-volk
added
the
🛠️ maintenance
|
Thanks for your work! Could you updated this PR so the newly introduced check actually pass? |
Signed-off-by: Christos Sidiropoulos <[email protected]>
|
I had actually left the files as they were and not updated them so that you can see the case directly when it fails :D But updated it now! |
|
One more thing: I have set node.js to version 12, but you can add more versions to test additionally. (eg. |
beatrycze-volk
approved these changes
Nov 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a GH workflow to check whether the compiled files are up to date with their sources.
It can easily happen that we commit code without grunt running, or merge a PR that is not up to date with master. This GH workflow causes the test to fail in such a case and you can do it afterwards.