Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split replace/delete original from response type #9

Closed
wants to merge 1 commit into from

Conversation

SiebeVE
Copy link

@SiebeVE SiebeVE commented Mar 28, 2022

Add ability to delete/replace original and change the response type.

This change isn't backwards compatible and should be considered a major change.

@jlindblom-godaddy
Copy link

The code looks good, but I don't understand the reason for it. Can you explain why it's necessary to split them? What have I overlooked?

@SiebeVE
Copy link
Author

SiebeVE commented Jun 1, 2022

It isn't possible if you want to add the directive replace_original and delete_original, you can only add one because it is stored in the same directive variable.

#[FauxProperty('response_type', 'replace_original', 'delete_original')]
public ?MessageDirective $directive;

This PR changes the behaviour and allows you to send replace_original and delete_original.
(Required if you want to change an ephemeral message with an in channel message)

@SiebeVE
Copy link
Author

SiebeVE commented Aug 8, 2022

See #19

@SiebeVE SiebeVE closed this Aug 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants