Detecting tab click with mousePressed instead of mouseClicked. #2097
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello! Changed
MouseAdapter
callback frommouseClicked
tomousePressed
. Reasons:MouseEvent.MOUSE_CLICKED
is only sent when there is no movement between press and release events, not even a single pixel. Maybe my mouse is too sensitive, but it is challenging to close or select a tab without significally slowing down the mouse or fully stopping it.BasicTabbedPaneUI.java
itself handles tab selecting withinmousePressed
(line 2611). As a result, the behavior differs when clicking at the tab's center compared (our handler) to clicking at its edges (parent's handler).