fix(gui): add missing sync in clean task at search dialog close (#2363)

skylot · Dec 21, 2024 · 73966fd · 73966fd
1 parent fe0ab5e
commit 73966fd
Show file tree

Hide file tree

Showing 3 changed files with 20 additions and 7 deletions.
diff --git a/jadx-core/src/main/java/jadx/core/dex/nodes/ClassNode.java b/jadx-core/src/main/java/jadx/core/dex/nodes/ClassNode.java
@@ -456,13 +456,15 @@ public void unload() {
 		if (state == NOT_LOADED) {
 			return;
 		}
-		methods.forEach(MethodNode::unload);
-		innerClasses.forEach(ClassNode::unload);
-		fields.forEach(FieldNode::unload);
-		unloadAttributes();
-		setState(NOT_LOADED);
-		this.loadStage = LoadStage.NONE;
-		this.smali = null;
+		synchronized (clsInfo) { // decompilation sync
+			methods.forEach(MethodNode::unload);
+			innerClasses.forEach(ClassNode::unload);
+			fields.forEach(FieldNode::unload);
+			unloadAttributes();
+			setState(NOT_LOADED);
+			this.loadStage = LoadStage.NONE;
+			this.smali = null;
+		}
 	}
 
 	private void buildCache() {

diff --git a/jadx-gui/src/main/java/jadx/gui/jobs/BackgroundExecutor.java b/jadx-gui/src/main/java/jadx/gui/jobs/BackgroundExecutor.java
@@ -22,6 +22,7 @@
 import org.slf4j.LoggerFactory;
 
 import jadx.api.utils.tasks.ITaskExecutor;
+import jadx.core.utils.exceptions.JadxRuntimeException;
 import jadx.gui.settings.JadxSettings;
 import jadx.gui.ui.MainWindow;
 import jadx.gui.ui.panel.ProgressPanel;
@@ -81,6 +82,15 @@ public synchronized void cancelAll() {
 		}
 	}
 
+	public synchronized void waitForComplete() {
+		try {
+			// add empty task and wait its completion
+			taskQueueExecutor.submit(UiUtils.EMPTY_RUNNABLE).get();
+		} catch (Exception e) {
+			throw new JadxRuntimeException("Failed to wait tasks completion", e);
+		}
+	}
+
 	public void execute(String title, List<Runnable> backgroundJobs, Consumer<TaskStatus> onFinishUiRunnable) {
 		execute(new SimpleTask(title, backgroundJobs, onFinishUiRunnable));
 	}

diff --git a/jadx-gui/src/main/java/jadx/gui/ui/dialog/SearchDialog.java b/jadx-gui/src/main/java/jadx/gui/ui/dialog/SearchDialog.java
@@ -182,6 +182,7 @@ public void dispose() {
 		removeActiveTabListener();
 		searchBackgroundExecutor.execute(() -> {
 			stopSearchTask();
+			mainWindow.getBackgroundExecutor().waitForComplete();
 			unloadTempData();
 		});
 		super.dispose();