Allow filtering by tags #69
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fragoulis
approved these changes
Nov 10, 2021
|
On a side note, I really do not like commits without commit messages. Please, put it the effort to explain the why and implementation details if applicable, no matter how obvious it may seem. |
|
Squash the commits into one please. |
jorge-wonolo
force-pushed
the
allow-tags
branch
from
1fcc6ca to
7e6d335
Compare
|
@jfragoulis thanks for the review, all your points should be addressed. |
fragoulis
reviewed
Nov 11, 2021
The rspec tag option allows allows you to include or exclude different specs. On our CI environment we actively use this to target testing on different components of our system.
jorge-wonolo
force-pushed
the
allow-tags
branch
from
21ed86b to
38f13ea
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simplified approach to pass through tags as command line variables.
Based on #47 not moving forward I think this is a simpler approach to pass in specific rspec tag arg