Skip to content

Commit

Permalink
Fix dependency and chrome installer code (#161)
Browse files Browse the repository at this point in the history
* Add libraries and update code

* Update missing dependency

* Update changelog
  • Loading branch information
d-shree authored May 28, 2024
1 parent e417975 commit 9248f35
Show file tree
Hide file tree
Showing 4 changed files with 6 additions and 5 deletions.
3 changes: 3 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,4 +1,7 @@
# Changelog
1.2.5
- [x] fix: Missing dependency in chrome installation

1.2.4
- [x] fix: Upgrade Selenium version

Expand Down
2 changes: 1 addition & 1 deletion Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ RUN conda install python=3.8 -y\
WORKDIR /home/kfp

RUN apt-get update && apt-get install -y --fix-missing \
libxss1 libappindicator1 libindicator7 jq \
libxss1 libappindicator1 libindicator7 libnss3 libatk-bridge2.0-0 jq \
&& rm -rf /var/lib/apt/lists/*

# Install latest Chrome
Expand Down
2 changes: 1 addition & 1 deletion pyproject.toml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
[tool.poetry]
name = "skit-pipelines"
version = "1.2.4"
version = "1.2.5"
description = "Kubeflow components for ml workflows at skit.ai."
authors = ["ltbringer <[email protected]>"]
license = "MIT"
Expand Down
4 changes: 1 addition & 3 deletions skit_pipelines/utils/cookies.py
Original file line number Diff line number Diff line change
Expand Up @@ -8,14 +8,12 @@
from selenium.webdriver.common.by import By
from selenium.webdriver.support import expected_conditions as EC
from selenium.webdriver.support.ui import WebDriverWait
from webdriver_manager.chrome import ChromeDriverManager

import skit_pipelines.constants as const


def simulate_selenium_connection(username, password) -> List[Dict[str, Any]]:
s = Service(ChromeDriverManager().install())

s = Service(executable_path='/usr/local/bin/chromedriver')
options = ChromeOptions()
options.add_argument("--window-size=1920,1080")
options.add_argument("--no-sandbox")
Expand Down

0 comments on commit 9248f35

Please sign in to comment.