fix: MenuButtonImageUpload should call insertImages prop #188
Conversation
lorenries
force-pushed
the
fix/menu-button-image-upload
branch
from
ec7b064 to
692b16f
Compare
There was a problem hiding this comment.
Great catch, thanks for opening the PR @lorenries! Just one minor suggestion, which should simplify things a bit and make it more consistent with some other similar code elsewhere.
| @@ -52,6 +55,7 @@ export interface MenuButtonImageUploadProps | |||
| export default function MenuButtonImageUpload({ | |||
| onUploadFiles, | |||
| inputProps, | |||
| insertImages, | |||
There was a problem hiding this comment.
For consistency with a similar use-case here:
mui-tiptap/src/controls/ColorPicker.tsx
Line 131 in 96a1cae
how about:
| insertImages, | |
| insertImages = insertImagesDefault, |
(importing with insertImages as insertImagesDefault instead of insertImages as fallbackInsertImages).
And then no need to update any of the code below (no conditional needed)
A refactored version of #188.
A refactored version of #188.
|
Thanks again for catching this bug and suggesting the fix! Since the final change is so small (with the refactor I suggested a few months back), I've gone ahead and made a separate smaller commit in a branch here #214. Closing this out. |
The
MenuButtonImageUploadcomponent doesn't actually call theinsertImagesprop, although it's defined in the type signature.