Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the sticky layout of Attribute View rows #9655

Merged
merged 3 commits into from
Nov 15, 2023

Conversation

Zuoqiu-Yingyi
Copy link
Contributor

  • Please commit to the dev branch
  • For contributing new features, please supplement and improve the corresponding user guide documents
  • For bug fixes, please describe the problem and solution via code comments
  • For text improvements (such as typos and wording adjustments), please submit directly

TESTED

@Zuoqiu-Yingyi Zuoqiu-Yingyi changed the title Perf/attr view row sticky Improve the sticky layout of Attribute View rows Nov 14, 2023
@Vanessa219 Vanessa219 merged commit 5862811 into siyuan-note:dev Nov 15, 2023
2 checks passed
Vanessa219 added a commit that referenced this pull request Nov 15, 2023
Vanessa219 added a commit that referenced this pull request Nov 15, 2023
@Zuoqiu-Yingyi
Copy link
Contributor Author

这里的跳动问题是性能问题,滚动停止时位置是一致的,原有实现位置不一致

界面样式问题是 _av.scss 改漏了的问题,需要添加 .av__body {float: left;} 即可解决

@Vanessa219
Copy link
Member

具体是哪里不一致?

@Zuoqiu-Yingyi
Copy link
Contributor Author

具体是哪里不一致?

使用 .av__body 替代原内联样式, 方便第三方样式调整该元素

  &__body {
    float: left;
  }

@Vanessa219
Copy link
Member

我问的不一致是 “这里的跳动问题是性能问题,滚动停止时位置是一致的,原有实现位置不一致”

@Zuoqiu-Yingyi
Copy link
Contributor Author

我问的不一致是 “这里的跳动问题是性能问题,滚动停止时位置是一致的,原有实现位置不一致”

当前版本没法复现, 可能在某次提交中顺便修复了

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants