Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix name attribute could not be visited in the plugin constructor #10071

Merged
merged 1 commit into from
Jan 7, 2024

Conversation

Zuoqiu-Yingyi
Copy link
Contributor

@Zuoqiu-Yingyi Zuoqiu-Yingyi commented Jan 3, 2024

修复在插件类构造函数中无法访问 name 属性的问题
Fixed the name attribute could not be visited in the plugin constructor.

REL: #9943

Copy link

github-actions bot commented Jan 3, 2024

Your PR was set to target master, PRs should be target dev
The base branch of this PR has been automatically changed to dev, please check that there are no merge conflicts

@Vanessa219
Copy link
Member

加载多个插件会报错。

@Zuoqiu-Yingyi
Copy link
Contributor Author

加载多个插件会报错。

错误输出是啥,我看我这里一切正常

@Vanessa219 Vanessa219 merged commit 796df79 into siyuan-note:dev Jan 7, 2024
3 checks passed
@Vanessa219
Copy link
Member

看了下是插件的问题,不是这个导致的。

@Vanessa219 Vanessa219 self-requested a review January 7, 2024 06:37
@Vanessa219 Vanessa219 added this to the 2.12.1 milestone Jan 7, 2024
EightDoor added a commit to EightDoor/siyuan that referenced this pull request Jan 7, 2024
* commit '796df799315490e3a9d6e045f1c6bc98fb661e45': (455 commits)
  🐛 Fix `name` attribute could not be visited in the plugin constructor (siyuan-note#10071)
  🎨 Support ignore index siyuan-note#9198
  ♻️ Rename func
  🎨 siyuan-note#10090
  🎨 Reduce the delay in adding rows in database table view siyuan-note#10082
  🎨 Reduce the delay in adding rows in database table view siyuan-note#10082
  🎨 siyuan-note#10065
  🎨 Cards expired no longer appear in the same review round siyuan-note#10087
  🎨 https://ld246.com/article/1704285860053/comment/1704528635155#comments
  🐛 fix siyuan-note#10088
  🎨 https://ld246.com/article/1704285860053
  🎨 fix siyuan-note#10086
  🎨 fix siyuan-note#10085
  🎨 fix siyuan-note#10048
  🎨 Add internal kernel API `/api/filetree/upsertIndexes` and `/api/filetree/removeIndexes` siyuan-note#10079
  🎨 fix siyuan-note#10083
  ⬆️ Upgrade kernel deps
  ⬆️ Upgrade kernel deps
  🎨 fix siyuan-note#10000
  🎨 siyuan-note#10065
  ...

# Conflicts:
#	app/src/util/needSubscribe.ts
#	kernel/model/conf.go
@Zuoqiu-Yingyi Zuoqiu-Yingyi deleted the fix/plugin-readonly-name branch January 7, 2024 07:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants