-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support jdk8 classes using lambdas #91
Support jdk8 classes using lambdas #91
Conversation
Current coverage is 84.79% (diff: 100%)@@ master #91 diff @@
==========================================
Files 41 41
Lines 868 868
Methods 0 0
Messages 0 0
Branches 174 174
==========================================
- Hits 737 736 -1
Misses 92 92
- Partials 39 40 +1
|
Hi @pedro-stanaka. Could you explain a little bit more about your idea? Did you have any problem to use f-f with Java 8 and lambdas expressions? I didn't see any changes in the core. Did you have problems with paranamer:2.5? cc/ @ahirata |
Hi, @aparra! My idea is only to upgrade the paranamer lib to version 2.8 which solves the problem. For more information check the issue #90 that I reported. |
Thanks @pedro-stanaka, I got it now. It looks good. Hey @ahirata / @nykolaslima, could you use this version run some tests? You guys have a bigger test suite. I guess if we don't have problems, we can merge it. |
Thanks guys, I look forward to the publication of a hotfix version in the repositories. 😃 |
Hey guys - I'm currently using lift, which piggybacks off this library. I'm running into the same issue as @pedro-stanaka and I'm wondering what the progress is on this PR. I sure could use it. Is there any intention to merge this in anytime soon? |
@ahirata could you take a look? |
Hi guys, this PR will be merging? I am using Lambda in compareTo method and paranamer throws a java.lang.ArrayIndexOutOfBoundsException. |
Hello guys! @ahirata @douglasrodrigo what is stopping this PR from being merged? Can I do something else? |
This PR is being submitted as means to solve issue #90. A quick summary of what I did in the PR:
If I am supposed to do improvements or fix any kind of error let me know.