Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support jdk8 classes using lambdas #91

Merged
merged 3 commits into from
May 27, 2018

Conversation

pedro-stanaka
Copy link
Contributor

This PR is being submitted as means to solve issue #90. A quick summary of what I did in the PR:

  1. Upgraded Paranamer library to 2.8
  2. Moved target and sorce java version to 1.8 (JDK 8) to use lambdas in tests.
  3. Added tests to make sure that classes with lambda expressions will work with fixture-factory.

If I am supposed to do improvements or fix any kind of error let me know.

@codecov-io
Copy link

Current coverage is 84.79% (diff: 100%)

Merging #91 into master will decrease coverage by 0.11%

@@             master        #91   diff @@
==========================================
  Files            41         41          
  Lines           868        868          
  Methods           0          0          
  Messages          0          0          
  Branches        174        174          
==========================================
- Hits            737        736     -1   
  Misses           92         92          
- Partials         39         40     +1   

Powered by Codecov. Last update fb057b3...489ad8d

@aparra
Copy link
Member

aparra commented Oct 11, 2016

Hi @pedro-stanaka. Could you explain a little bit more about your idea?

Did you have any problem to use f-f with Java 8 and lambdas expressions? I didn't see any changes in the core. Did you have problems with paranamer:2.5?

cc/ @ahirata

@pedro-stanaka
Copy link
Contributor Author

pedro-stanaka commented Oct 11, 2016

Hi, @aparra! My idea is only to upgrade the paranamer lib to version 2.8 which solves the problem.
The only thing I did after that was to add some tests to ensure that f-f is going to be able to resolve constructor parameters using the new version of paranamer.

For more information check the issue #90 that I reported.

@aparra
Copy link
Member

aparra commented Oct 12, 2016

Thanks @pedro-stanaka, I got it now. It looks good.

Hey @ahirata / @nykolaslima, could you use this version run some tests? You guys have a bigger test suite. I guess if we don't have problems, we can merge it.

@pedro-stanaka
Copy link
Contributor Author

Thanks guys, I look forward to the publication of a hotfix version in the repositories. 😃

@tbockman-rms
Copy link

Hey guys - I'm currently using lift, which piggybacks off this library. I'm running into the same issue as @pedro-stanaka and I'm wondering what the progress is on this PR. I sure could use it.

Is there any intention to merge this in anytime soon?

@douglasrodrigo
Copy link
Member

@ahirata could you take a look?

@ignacio83
Copy link

Hi guys, this PR will be merging? I am using Lambda in compareTo method and paranamer throws a java.lang.ArrayIndexOutOfBoundsException.

@pedro-stanaka
Copy link
Contributor Author

Hello guys! @ahirata @douglasrodrigo what is stopping this PR from being merged? Can I do something else?

@douglasrodrigo douglasrodrigo merged commit 5239ccd into six2six:master May 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants