Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: #182, YAML Config File Generation #211

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

cchunduri
Copy link

@cchunduri cchunduri commented Jul 29, 2024

What is this PR bringing?

As discussed in #182, this PR will bring the option to generate resource config files in YAML format.

  • Dev testing
  • Unit tests

@cchunduri cchunduri marked this pull request as draft July 29, 2024 17:48
@cchunduri cchunduri marked this pull request as ready for review July 31, 2024 19:41
@cchunduri cchunduri changed the title WIP: Feature: #182, YAML Config File Generation Feature: #182, YAML Config File Generation Jul 31, 2024
@rajadilipkolli
Copy link
Collaborator

Hi @cchunduri , very good work on providing PR. only few minor comments needs to be addressed.

Can you also update the ReadMe file with this change.

@cchunduri
Copy link
Author

@rajadilipkolli Thank you for your review.

In README.md, do I need to update features section? Could please elaborate?

@sivaprasadreddy
Copy link
Owner

Hi @cchunduri
Can you please add a couple of tests (one for Maven and one for Gradle) to make sure that the application configuration is proper and can be successfully bootstrapped?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants