Skip to content

Commit

Permalink
Smooth min/max weight reverted to default of 1
Browse files Browse the repository at this point in the history
  • Loading branch information
mossr committed Dec 13, 2023
1 parent bac3b79 commit 34c4280
Show file tree
Hide file tree
Showing 4 changed files with 6 additions and 6 deletions.
4 changes: 2 additions & 2 deletions notebooks/runtests.html

Large diffs are not rendered by default.

4 changes: 2 additions & 2 deletions notebooks/stl.html

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion src/stl.jl
Original file line number Diff line number Diff line change
Expand Up @@ -268,7 +268,7 @@ md"""
"""

# ╔═╡ ba0a977e-3dea-4b87-900d-d7e2e4281f79
global W = Inf # i.e., default to returning the mean
global W = 1

# ╔═╡ 053e0902-559f-4ac9-98dc-4b59f11e4056
function logsumexp(x)
Expand Down
2 changes: 1 addition & 1 deletion test/runtests.jl
Original file line number Diff line number Diff line change
Expand Up @@ -550,7 +550,7 @@ end
@test smoothmax(sm; w=Inf) == mean(sm)

# ╔═╡ e28af833-ebc3-4767-a5ba-0c2f5dbbc028
@test robustness(x, ϕ_always; w=Inf) == smooth_robustness(x, ϕ_always)
@test robustness(x, ϕ_always; w=1) == smooth_robustness(x, ϕ_always)

# ╔═╡ dded9b53-c9d4-47b1-9cd2-ca5a3cd245fb
@test robustness(x, ϕ_always) == ρ(x, ϕ_always)
Expand Down

2 comments on commit 34c4280

@mossr
Copy link
Member Author

@mossr mossr commented on 34c4280 Jan 30, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JuliaRegistrator
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Registration pull request created: JuliaRegistries/General/99825

Tip: Release Notes

Did you know you can add release notes too? Just add markdown formatted text underneath the comment after the text
"Release notes:" and it will be added to the registry PR, and if TagBot is installed it will also be added to the
release that TagBot creates. i.e.

@JuliaRegistrator register

Release notes:

## Breaking changes

- blah

To add them here just re-invoke and the PR will be updated.

Tagging

After the above pull request is merged, it is recommended that a tag is created on this repository for the registered package version.

This will be done automatically if the Julia TagBot GitHub Action is installed, or can be done manually through the github interface, or via:

git tag -a v0.1.0 -m "<description of version>" 34c428074ccd17af1921d4e8dd8dc8d86e724178
git push origin v0.1.0

Please sign in to comment.