-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(input): Input 컴포넌트 구현 #23
Open
froggy1014
wants to merge
22
commits into
main
Choose a base branch
from
feat/input
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+632
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
froggy1014
requested review from
kimdaeyeobbb,
hy57in,
developerjhp,
bae-sh,
noahluftyang,
heeji289 and
synuns
as code owners
November 17, 2024 12:54
Open
코드 포맷팅이 제대로 적용되어있지 않은 것 같은데, vscode에 biome extension 설치 되어있는지 확인 부탁드려도 될까요?! |
그래도 전체적으로 코드가 잘 정돈되어있고 고민의 흔적들이 많이 보여서 좋았어요!! 👍👍👍 |
맞습니다. 어째서인지 Disable이 되어있었네요. 어째... 피드백 반영했습니다. 감사합니다 ㅎㅎ |
noahluftyang
approved these changes
Nov 19, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
변경사항
Compound Pattern으로 구현해보려고 했었는데,
저희 Input 관련해서는 타입마다 다 컴포넌트로 나눠져 있는거 같습니다.
각 컴포넌트는 분리하고,
<Form />
같은 컴포넌트로 감싸서 그 안에서 유틸리티 컴포넌트를 제공하는 방향이 더 낫겠다 싶어서, Input은 딱 그 역할만 잘할 수 있게끔 작성을 해보았습니다.시각자료
체크리스트
추가 논의사항
임시로
spacing
,color
를 정한 부분이 있는데 그건 추후 컨벤션 정해서 고쳐나가야할 것 같습니다..그 외 질문이나.. 관련해서 코멘트 달아주시면 감사하겠습니다 -