Update scripts and docs to reflect changes in settings file. #436
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
June 2, 2023 09:15
|
This is beautiful - thank you! Let's finish up #409 and get these in too! 🎉 |
vsoch
reviewed
Jun 2, 2023
shub/settings.py
Outdated
| @@ -668,4 +668,20 @@ def __iter__(self): | |||
| } | |||
|
|
|||
| if ENABLE_GITLAB_AUTH: # noqa | |||
| SOCIAL_AUTH_GITLAB_SCOPE = ["api", "read_user"] | |||
| if "SOCIAL_AUTH_GITLAB_SCOPE" not in locals(): | |||
There was a problem hiding this comment.
Looks like this change from the other PR snuck in!
There was a problem hiding this comment.
i mentioned that is relies on changes from the #435 because the scripts need that other script to work properly.
added 11 commits
June 2, 2023 15:49
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates a few things that were changed in #409.
Relies on changes in #435
blocked by #435