Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding component_price_points endpoint #44

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Adding component_price_points endpoint #44

wants to merge 4 commits into from

Conversation

amakalin4
Copy link
Contributor

Description of change

Adding endpoint for component price points. Current schemas only contain price points for products.

Manual QA steps

  • Re-run Singer Tap to see if new endpoint is picked up

Risks

  • Passed successfully during local testing, but would like another check before merging

Rollback steps

  • revert this branch

amakalin4 added 4 commits June 23, 2021 14:01
@amakalin4
Create component_price_points.json
516f8f5
@amakalin4
Update chargify.py
8b6202d 
added function to pull new endpoint `component_price_points.json`
@amakalin4
Update streams.py
de17679 
Added `component_price_points` to stream
@amakalin4
Update chargify.py
260678f 
Streamlining naming convention
@Punita1790
Copy link

Hi @cosimon, Could you please approve and merge this PR at your earliest? thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@amakalin4 @Punita1790