awesome-list-item Fix for "Bug with selection of link to validate" - Fixes #199
#201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Links to sindresorhus#199 Also see sancarn/awesome-vba#12 for reference
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #199
The previous algorithm solved for pattern:
[^{link}{linkReference}]* ({link}|{linkReference}) [^{link}]* " - " {description}The new algorithm solves for pattern:
{any}* ({link}|{linkReference}) [^{link}]* " - " {description}?It does this by finding a text node starting with
-. This node and those after are the description, and nodes before are searched backwards to find a valid {link} or {linkReference}. This will be the checked link.References
Links to #199
Issue identified in sancarn/awesome-vba#12
Related PR: #185