Remove default option --format from weasyprint command #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Includes updated rspec because the previous version wasn't working any more
…weasyprint-command Remove --format from weasyprint command
|
We are also trying to use this gem and running into the same issue. Any idea who can help with getting this merged? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WeasyPrint v54 doesn't support --format anymore.
Also: the specs were broken ("NameError: uninitialized constant RSpec::Expectations::MultipleExpectationsNotMetError") so I upgraded RSpec to fix that. Some specs are still failing.
Hope this is helpful at all. It's my first public pull request ever. :)