Context providers refactor #90
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There were no tests of that code path, only using the context_provider method.
wjlroe
force-pushed
the
context-providers-refactor
branch
from
b55312e to
3eb4d5e
Compare
Maintaining the existing API to the initializers and the context_provider method. This is just simpler - without the need to wrap lambdas within other lambdas. It should also be easier to understand and read as a result.
wjlroe
force-pushed
the
context-providers-refactor
branch
from
3eb4d5e to
e4c3f9c
Compare
|
/dobby version minor |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This refactors context providers to an array of lambdas, rather than wrapping lambdas within other lambdas. This is mostly for simplicity in general - in terms of understanding, reading, debugging. It should be easier to understand the state your logger is in, because the syntax location of any context providers should point to their actual location in code, rather than the wrapping lambda that's within
lib/twiglet/logger.rb. This should be backwards compatible with existing code (that's the intention). This also adds a little bit of extra test coverage (i.e. passing a context provider to theLoggerinitializer).