Revoke sudo permissions #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zinggi
reviewed
Oct 18, 2023
Zinggi
reviewed
Oct 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The role is currently not able to revoke sudo permissions for users. With this PR, this is added. The first commit adds a failing test, while the second one includes the actual implementation.
I'm personally a bit disappointed that Ansible does not have any nice native tools to remove groups on a user. Using
commandto retrieve groups, and then transforming the resulting output feels very hacky. I made a couple of tries withgetent, but it ended up in a nightmare of Jinja transformations.