WIP move to SSP UI #267
Draft
WIP move to SSP UI #267
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## wip-version-6 #267 +/- ##
===================================================
- Coverage 43.33% 41.88% -1.46%
- Complexity 1343 1396 +53
===================================================
Files 143 150 +7
Lines 5631 5826 +195
===================================================
Hits 2440 2440
- Misses 3191 3386 +195 ☔ View full report in Codecov by Sentry. |
|
Cool! Thanks for quick feedback for now.. |
added 2 commits
November 14, 2024 16:50
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is still WIP.
I'm trying to incorporate OIDC module pages into standard SSP UI.
I've intended to include "standard horizontal menu" (marked yellow in picture below) from the
adminmodule on all OIDC related pages. Using thehook_adminmenuis easy when we are inadminmodule, but I'm wondering if the solution that I've used (src/Factories/TemplateFactory.php:65) to include it in OIDC module is OK in your oppinion @tvdijen .